Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Install git-delta for nicer diffs in error messages #729

Merged
merged 1 commit into from
Jan 21, 2025
Merged

ci: Install git-delta for nicer diffs in error messages #729

merged 1 commit into from
Jan 21, 2025
+1 −0

Conversation

adombeck
Copy link
Contributor

@adombeck adombeck commented Jan 15, 2025 •
edited
Loading

The diffs of mismatching golden files are passed through git-delta since #645.

@adombeck
ci: Install git-delta for nicer diffs in error messages
d964d58 
The diffs of mismatching golden files are passed through git-delta since
#645.
@adombeck adombeck changed the title ci: Install git-delta ci: Install git-delta for nicer diffs in error messages Jan 15, 2025
@adombeck
Copy link
Contributor Author

The failing tests are known to be flaky (#730, #713)

@adombeck adombeck marked this pull request as ready for review January 15, 2025 16:10
@adombeck adombeck requested a review from a team as a code owner January 15, 2025 16:10
@adombeck adombeck requested a review from didrocks January 17, 2025 13:52
@adombeck
Copy link
Contributor Author

@didrocks ping

didrocks
didrocks approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have the feature easily unlock as we have the common repo!

@adombeck
Copy link
Contributor Author

Nice to have the feature easily unlock as we have the common repo!

We don't have a common repo yet though, it's two copies of the same code (

authd/internal/testutils/golden/golden.go

Line 163 in ab2da28

func runDelta(diff string) (string, error) {
and https://github.com/ubuntu/authd-oidc-brokers/blob/5b3682390d32d25054781f0bd7997fb3b600630b/internal/testutils/golden/golden.go#L163-L163).

@adombeck adombeck merged commit 07001a9 into main Jan 21, 2025
9 of 11 checks passed
@adombeck adombeck deleted the install-git-delta branch January 21, 2025 13:16
@didrocks
Copy link
Member

Ah, my turn to have failing memories :) I was trapped by the additional dep as the only diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adombeck @didrocks