Replace spaces in test names with underscores

[adombeck]

To make it easier to copy/paste them into a go test -run command.

FTR, this command can be used to reproduce the changes:

for i in {1..20}; do
  find . -name "*.go"  -not -path "./vendor/*" -not -path "./obj-x86_64-linux-gnu/*" -not -path "./scratch/*" -exec sed -i -E 's/"([^"]+)"([[:space:]]*:[[:space:]]*\{)/"\1"\2/g; s/([^"_])\s+([^"]*":[[:space:]]*\{)/\1_\2/g' {} \;
done

UDENG-5822

[didrocks]

I quickly scanned through them and didn’t spot anything. Between that and checking that no golden files have been "traumatized" in that PR, let’s +1! :)

[3v1n0]

Looks nice!

One thing... If you have a regex or automated script for this (I hope so), could you wait that we land #593 first to avoid the conflicts and re-run it? :)

[adombeck]

One thing... If you have a regex or automated script for this (I hope so), could you wait that we land #593 first to avoid the conflicts and re-run it? :)

I rebased the branch from that PR on this one by executing

git rebase main

cat <<EOF > /tmp/replace-spaces.sh
for i in {1..20}; do
  find . -name "*.go"  -not -path "./vendor/*" -not -path "./obj-x86_64-linux-gnu/*" -not -path "./scratch/*" -exec sed -i -E 's/"([^"]+)"([[:space:]]*:[[:space:]]*\{)/"\1"\2/g; s/([^"_])\s+([^"]*":[[:space:]]*\{)/\1_\2/g' {} \;
done
EOF

git rebase -X theirs UDENG-5822-rename-tests --exec 'sh /tmp/replace-spaces.sh'

And then amending the commits during the rebase. If you're fine with that, I can push to your branch and we can merge this one.