Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue template: Use sudo to collect config file contents #769

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

adombeck
Copy link
Contributor

@adombeck adombeck commented Jan 29, 2025

The config files are only readable by root since 9ff0d1a and ubuntu/authd-oidc-brokers@6116ba9.

@adombeck adombeck requested a review from a team as a code owner January 29, 2025 12:36
@adombeck adombeck requested a review from didrocks January 29, 2025 12:37
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely spotted! We should ship an apport hook for collecting bug info btw.

@adombeck
Copy link
Contributor Author

adombeck commented Jan 29, 2025

I'd like to point out that it doesn't make sense to me to, on the one hand, protect the contents of /etc/authd/brokers.d from unprivileged local users, and on the other hand make users paste its contents into a public GitHub issue. I don't want to restart the discussion from #753 (comment) though.

@adombeck
Copy link
Contributor Author

nicely spotted! We should ship an apport hook for collecting bug info btw.

yeah, I think we have a ticket for that

@adombeck adombeck merged commit 8741a04 into main Jan 29, 2025
13 of 14 checks passed
@adombeck adombeck deleted the fix-issue-template branch January 29, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants