Use SQLite instead of bbolt #779
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes done by running: git rm "internal/*/testdata/golden/*" TESTS_UPDATE_GOLDEN=1 go test ./internal/... git add -A
We don't use our database as a cache anymore. It's time to reflect this in the package name.
We can't use the "AAAAATIME" placeholders anymore when using SQLite, because the schema only allows actual timestamps.
These files were forgotten in 5555836. Also simplify the testdata for the "pam_unix_non_existent" test case, because we don't need multiple users and groups for that test case.
adombeck
force-pushed
the
UDENG-4890-use-sqlite
branch
from
763b8ed to
99bfaab
Compare
adombeck
commented
Feb 7, 2025
Comment on lines
+65
to
+73
| // TODO: I don't see why we should fail here instead of just fixing the permissions. | ||
| fileInfo, err := os.Stat(dbPath) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("can't stat database file: %v", err) | ||
| } | ||
| perm := fileInfo.Mode().Perm() | ||
| if perm != 0600 { | ||
| return nil, fmt.Errorf("wrong file permission for %s: %o", dbPath, perm) | ||
| } |
There was a problem hiding this comment.
To the reviewer: I copied this from the old code but added this TODO comment:
// TODO: I don't see why we should fail here instead of just fixing the permissions.
Is there a good reason for failing or should we just fix the permissions?
adombeck
commented
Feb 7, 2025
Comment on lines
+33
to
+41
| // It prevents leaking of lastLogin, which is only relevant to the database. | ||
| // TODO: The only consumer of this package is the users manager, which converts the UserDB into a types.UserEntry anyway, | ||
| // | ||
| // so there is no need to hide the lastLogin field (which complicates the code). | ||
| type userRow struct { | ||
| UserDB `yaml:",inline"` | ||
| // TODO: Why do we store the last login time in the database? It's not used anywhere. | ||
| LastLogin time.Time `yaml:"last_login,omitempty"` | ||
| } |
There was a problem hiding this comment.
@didrocks @denisonbarbosa: Do you remember why we store the last login time even though it's not used?
adombeck
commented
Feb 7, 2025
Comment on lines
+1
to
+12
| CREATE TABLE IF NOT EXISTS users ( | ||
| name TEXT NOT NULL UNIQUE, | ||
| uid INTEGER NOT NULL UNIQUE, | ||
| gid INTEGER NOT NULL, | ||
| gecos TEXT DEFAULT "", | ||
| home TEXT DEFAULT "", | ||
| shell TEXT DEFAULT "/bin/bash", | ||
| last_login DATE, | ||
| broker_id TEXT DEFAULT "", | ||
| PRIMARY KEY(uid) | ||
| ); | ||
| CREATE UNIQUE INDEX "idx_user_name" ON users ("name"); |
There was a problem hiding this comment.
@jibel You mentioned in a call that you would prefer to not use the UNIQUE constraint in the schema, but I did not understand the reasoning. Can you please explain it again, so that I can update the schema and add a code comment with the reasoning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our database requirements are better met by a relational database than a key value store, so we now use SQLite instead of bbolt.
UDENG-4890