Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to core24, use newer qemu-virgil update gnome-boxes to 47 and depedency to stable releases and support USB redirection #28

Merged
merged 19 commits into from
Jan 20, 2025

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Jan 20, 2025

Description

  • Update to qemu, that required core24, that required some further updates...
  • Enable and fix support for USB redirection (requires some manual intervention, so added a new dialog to inform the user about).
  • Random cleanups

See commits for details and rationale.

Type of change

Please check only the options that are relevant.

  • General Maintenance
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Close: #4, #26, #25

@3v1n0 3v1n0 requested a review from sergio-costas January 20, 2025 06:43
This was linked to issues Jan 20, 2025
3v1n0 added 19 commits January 20, 2025 09:17
We already build libvirt ourself, so there's no need to depend on it
qemu-virgil has a very old stable release, so we want to track edge as
we used to do before.

However the latest qemu-virgil is based on core24 so we should do the
same or we'll end up in ABI / API issues (as various libraries won't
match).

So let's do it, but we also require some more changes though, in
particular:
 - Bump libvirt version (using the old one was almost possible after
   some patching, but qemu is just too new at this point to work with a
   such old version of libvirt, so let's get the newest one we can)
 - drop custom libphodav: just use the archive version
 - Expose the libvirt daemons to the $PATH
 - Adapt pci.ids path to be in the (legacy) expected one by libvirt
 - Adapt some commands and dependencies
This can work without any previous requirement
The order here doesn't matter much
It's the latest stable version and safe enough to use
Although the usb access isn't working yet by default, but let's at least
add all the dependencies and move the ones they belong to
And also it avoids being blocked by the confinement when trying to set
the ACL.
…devices

It allows proper USB redirection, but it requires user intervention
It's not required being already implicit
It's not required anymore as per upstream commit dbc5cc586 (44.0), so
remove it for us too
Copy link
Contributor

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the snap, and did these tests:

  • run a pre-installed box, made with the previous version ✔
  • install a new box downloading the ISO from boxes itself ✔
  • install a new box from an already downloaded ISO ✔

So, LGTM.

@sergio-costas sergio-costas merged commit fb5b4f2 into ubuntu:stable Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add removable-media permission Update GNOME Boxes to 46.0 Disable USB redirection
2 participants