-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to core24, use newer qemu-virgil update gnome-boxes to 47 and depedency to stable releases and support USB redirection #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 20, 2025
It's totally not required by it
We already build libvirt ourself, so there's no need to depend on it
qemu-virgil has a very old stable release, so we want to track edge as we used to do before. However the latest qemu-virgil is based on core24 so we should do the same or we'll end up in ABI / API issues (as various libraries won't match). So let's do it, but we also require some more changes though, in particular: - Bump libvirt version (using the old one was almost possible after some patching, but qemu is just too new at this point to work with a such old version of libvirt, so let's get the newest one we can) - drop custom libphodav: just use the archive version - Expose the libvirt daemons to the $PATH - Adapt pci.ids path to be in the (legacy) expected one by libvirt - Adapt some commands and dependencies
This can work without any previous requirement
The order here doesn't matter much
It's the latest stable version and safe enough to use
Although the usb access isn't working yet by default, but let's at least add all the dependencies and move the ones they belong to
And also it avoids being blocked by the confinement when trying to set the ACL.
…devices It allows proper USB redirection, but it requires user intervention
It's not required being already implicit
It's not required anymore as per upstream commit dbc5cc586 (44.0), so remove it for us too
3v1n0
force-pushed
the
update-24.04-47
branch
from
January 20, 2025 08:19
72c6c79
to
958d3fe
Compare
sergio-costas
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built the snap, and did these tests:
- run a pre-installed box, made with the previous version ✔
- install a new box downloading the ISO from boxes itself ✔
- install a new box from an already downloaded ISO ✔
So, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See commits for details and rationale.
Type of change
Please check only the options that are relevant.
Close: #4, #26, #25