Fix glib-mkenums #261
Merged
Fix glib-mkenums #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'conditioning' part is replacing '/usr/bin/python' in glib- mkenums file with '/usr/bin/python3', to ensure that it works with the current builds. Unfortunately, this only works if the original shebang was referring to python2. The current version of glib-mkenums, instead, has a shebang that already points to python3, so the result of the sed command is a shebang that points to python33, resulting in an execution error. This patch fixes it by ensuring that the replacement is done only if the shebang points to "python", but not if it points to "python3". Fix ubuntu#260
seb128
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Thanks. The existing code seems weird, basically it is making the interpreter be "#!python3" which isn't valid right?
Could we simply remove that sed call instead?
We know that glib is using python3 in noble and it will not go back, is there really a case where it would ever do something?
|
Yes, you are right. Also, I missed the fact that it removed the Done the removal. But, just in case, wait until I test it. |
|
Confirmed: it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'conditioning' part is replacing '/usr/bin/python' in glib- mkenums file with '/usr/bin/python3', to ensure that it works with the current builds. Unfortunately, this only works if the original shebang was referring to python2. The current version of glib-mkenums, instead, has a shebang that already points to python3, so the result of the sed command is a shebang that points to python33, resulting in an execution error.
This patch fixes it by ensuring that the replacement is done only if the shebang points to "python", but not if it points to "python3".
Fix #260