Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all tests and documentation #262

Conversation

sergio-costas
Copy link
Contributor

This PR disables, during the building of parts, all the tests and documentation build, and also enables building gobject introspection data and VAPI files, to ensure that all libraries are available in any language.

It also removes the usr/share/gtk-doc folder, since it's not needed.

All this saves a little bit of space and slightly reduces the build time.

This PR disables, during the building of parts, all the tests
and documentation build, and also enables building gobject
introspection data and VAPI files, to ensure that all libraries
are available in any language.

It also removes the usr/share/gtk-doc folder, since it's not
needed.

All this saves a little bit of space and slightly reduces the
build time.
@sergio-costas sergio-costas marked this pull request as draft November 21, 2024 13:06
@sergio-costas sergio-costas marked this pull request as ready for review December 18, 2024 14:32
@kenvandine
Copy link
Member

This disables building and running the tests right? It's not about installing the tests? I think I'd prefer running the tests anywhere we can just so we can get build failures when an expected passing tests fails.

@sergio-costas
Copy link
Contributor Author

But, AFAIK, those tests are built but not run...

Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Ken that running the tests would be better but also Sergio has a point that the standard target isn't running tests (confirmed by checking the build log) so that isn't a functional change and should win us some build time/disk space.

@kenvandine seems reasonable?

@kenvandine
Copy link
Member

I agree with Ken that running the tests would be better but also Sergio has a point that the standard target isn't running tests (confirmed by checking the build log) so that isn't a functional change and should win us some build time/disk space.

@kenvandine seems reasonable?

Yeah, sounds reasonable.

Copy link
Member

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kenvandine kenvandine merged commit b58e3bc into ubuntu:gnome-46-2404-sdk Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants