Revert librsvg to version 2.58.1 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required because version 2.59.1 changes the name of the gdk-pixbuf-loader from libpixbufloader-svg.so to libpixbufloader_svg.so, which breaks snaps because each snap stores its own loaders.cache file with the path for each loader, so an already installed snap will have a loaders.cache file with a svg loader path pointing to the former name, but the current file would be the later, thus it won't be able to load any svg. The right solution is to modify snapcraft-desktop-integration scripts to add a check that rebuilds any cache (not only pixbuf loaders, but also fonts, icons...) not only if the snap itself is updated, but also if any of the extensions is updated too. Fix ubuntu#257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required because version 2.59.1 changes the name of the gdk-pixbuf-loader from libpixbufloader-svg.so to
libpixbufloader_svg.so, which breaks snaps because each snap stores its own loaders.cache file with the path for each loader, so an already installed snap will have a loaders.cache file with a svg loader path pointing to the former name, but the current file would be the later, thus it won't be able to load any svg.
Reverting the version also forces to revert from meson to autotools.
The right solution is to modify snapcraft-desktop-integration scripts to add a check that rebuilds any cache (not only pixbuf loaders, but also fonts, icons...) not only if the snap itself is updated, but also if any of the extensions is updated too.
Fix #257