Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons: reorganize org.gnome.Settings* symbolic icons #4065

Merged
merged 1 commit into from
Apr 1, 2024
Merged

icons: reorganize org.gnome.Settings* symbolic icons #4065

merged 1 commit into from
Apr 1, 2024

Conversation

Muqtxdir
Copy link
Member

changes:

  • since couple of past few releases settings has quite few re-orgs with icon dir and icon-names and it was not easy to track the changes/diff to upstream, hence all symbolic-icons associated with settings have been moved under org.gnome.Settings directory to track it one place.
  • removed symlinks as these icons have been updated/touched in recent cycles, better to have them distinct.
  • added missing symbolics and updated few symbolics to match upstream representation :)

screenshots:

icons screenshot
system, region, date, about Screenshot from 2024-04-01 02-06-25
privacy* Screenshot from 2024-04-01 02-06-33

@Muqtxdir Muqtxdir requested review from Feichtmeier and Jupi007 March 31, 2024 20:45
Feichtmeier
Feichtmeier approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM

@Feichtmeier
Copy link
Member

Does this failed test has any relevance to the icons changed?

The following packages have unmet dependencies:
gnupg2 : Depends: gnupg (>= 2.4.4-2ubuntu15) but it is not installable

Jupi007
Jupi007 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, LGTM !
Thanks a lot @Muqtxdir

@Muqtxdir
Copy link
Member Author

Muqtxdir commented Apr 1, 2024

thanks everyone!

@Muqtxdir Muqtxdir merged commit 65624a3 into master Apr 1, 2024
4 of 5 checks passed
@Muqtxdir Muqtxdir deleted the refactor/settings-symbolics branch April 1, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Muqtxdir @Feichtmeier @Jupi007