Merge with GNOME Shell 47 changes #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was cool hacky code, but it's not needed anymore since the shell can do colored assets without this, so drop this to simplify the whole logic
We prefer keeping the multi-css based theming for now since it allows further customization based on the accent itself (as the warty brown!). But we can likely ignore those in future.
3v1n0
force-pushed
the
gnome-shell-47
branch
from
5bb4174 to
920340e
Compare
Muqtxdir
approved these changes
Sep 6, 2024
|
Thanks @3v1n0 ! |
|
@Jupi007 there are still few glitches around, so feel free to reiterate if you've time :) |
|
@3v1n0 I'll try to check it out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still keep some custom things for tuning better the accent colors, but that will go next cycle