fix: fix test for billing check

uc-cdis · Nov 13, 2023 · b94b7b0 · b94b7b0
1 parent f86a632
commit b94b7b0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/src/argowrapper/routes/routes.py b/src/argowrapper/routes/routes.py
@@ -184,8 +184,9 @@ def submit_workflow(
 ) -> str:
     """route to submit workflow"""
     try:
-        # check if user has a billing id tag"""
+        # check if user has a billing id tag:
         billing_id = check_user_billing_id(request)
+        # submit workflow:
         return argo_engine.workflow_submission(
             request_body, request.headers.get("Authorization"), billing_id
         )

diff --git a/test/test_routes.py b/test/test_routes.py
@@ -515,12 +515,13 @@ def test_check_user_billing_id(client):
 
             mock_resp.status_code == 500
             mock_resp.raise_for_status.side_effect = Exception("fence is down")
-            with pytest.raises(Exception):
-                response = client.post(
-                    "/submit",
-                    data=json.dumps(data),
-                    headers={
-                        "Content-Type": "application/json",
-                        "Authorization": EXAMPLE_AUTH_HEADER,
-                    },
-                )
+            response = client.post(
+                "/submit",
+                data=json.dumps(data),
+                headers={
+                    "Content-Type": "application/json",
+                    "Authorization": EXAMPLE_AUTH_HEADER,
+                },
+            )
+            assert response.status_code == 500
+            assert "fence is down" in str(response.content)