Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: convert team_project labels to valid pod labels #110

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix: convert team_project labels to valid pod labels #110

merged 1 commit into from
Nov 7, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Nov 7, 2023 •
edited by jira bot
Loading

Jira Ticket: VADC-796

Bug Fixes

  • convert team_project labels to valid pod labels. This fix allows "team project" names to have many types of special characters, including /

m0nhawk
m0nhawk approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pieterlukasse pieterlukasse merged commit ca7dda1 into master Nov 7, 2023
4 of 5 checks passed
@pieterlukasse pieterlukasse deleted the fix/convert_teamproject_to_valid_pod_label branch November 7, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nhawk m0nhawk m0nhawk approved these changes

@tianj7 tianj7 Awaiting requested review from tianj7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @m0nhawk