Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/metadata label parsing #118

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Nov 15, 2023

Jira Ticket: VADC-811

Bug Fixes

  • add missing items.metadata.labels to fields selection to fix a crash when listing running workflows
  • add missing call to convert_pod_label_to_gen3teamproject to return the decoded string for the team project label in the response

@pieterlukasse pieterlukasse requested a review from tianj7 November 15, 2023 17:47
@pieterlukasse pieterlukasse force-pushed the fix/metadata_label_parsing branch from d598e65 to 7ce1f9a Compare November 15, 2023 18:04
Copy link
Contributor

@tianj7 tianj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pieterlukasse pieterlukasse merged commit a136ab3 into master Nov 15, 2023
4 checks passed
@pieterlukasse pieterlukasse deleted the fix/metadata_label_parsing branch November 15, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants