Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more conditions in gwas function #153

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

wangfan860
Copy link
Contributor

Improvements

The updated condition makes it clear that:

  • "system is exactly singular" error message applies to both "run-null-model" and "run-single-assoc"
  • "system is computationally singular" error message applies to both "run-null-model" and "run-single-assoc"

Related discussion

https://cdis.slack.com/archives/C01A12E8NUR/p1731421219821819

Copy link
Contributor

@vzpgb vzpgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@wangfan860 wangfan860 merged commit 72ccfd4 into master Nov 12, 2024
9 of 11 checks passed
@wangfan860 wangfan860 deleted the wangfan860-patch-1 branch November 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants