Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ownedByCTDS config to dataguid dist #4091

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add ownedByCTDS config to dataguid dist #4091

wants to merge 2 commits into from

Conversation

jingh8
Copy link
Contributor

@jingh8 jingh8 commented Jan 28, 2022

The dataguid test will skip the hosts which are not owned by CTDS

@jingh8 jingh8 requested a review from paulineribeyre January 28, 2022 21:12
@jingh8 jingh8 requested a review from trevars as a code owner January 28, 2022 21:12
paulineribeyre
paulineribeyre requested changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add in the tests a hardcoded list of systems we want to use, instead? i don’t know how i feel about adding in a production manifest config that’s only for the tests

@m0nhawk m0nhawk requested a review from a team as a code owner May 2, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre requested changes

@trevars trevars Awaiting requested review from trevars trevars is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
test-portal-dataguidOrgTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingh8 @paulineribeyre @PlanXCyborg