Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update va-testing portal to 5.37.0 #8352

Merged
merged 1 commit into from
Feb 6, 2025
Merged

update va-testing portal to 5.37.0 #8352

merged 1 commit into from
Feb 6, 2025

Conversation

ocshawn
Copy link
Contributor

@ocshawn ocshawn commented Feb 6, 2025 •
edited by jira bot
Loading

Link to Jira ticket if there is one: VADC-1639

Environments

  • va-testing

Description of changes

  • Refactor logout popup logic to show on all pages except login page
  • Refactor popup to have focus
  • add aria-hidden='true' to overlooked error page

@ocshawn ocshawn requested review from nmetokishlubsky and a team as code owners February 6, 2025 19:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

va-testing.data-commons.org/manifest.json

⚠️ Services on branch

  • ohdsi-atlas
  • ohdsi-webapi

@ocshawn ocshawn merged commit fc22823 into master Feb 6, 2025
3 checks passed
@ocshawn ocshawn deleted the chore/vaTestPortal branch February 6, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigrbarnes craigrbarnes craigrbarnes approved these changes

@mfshao mfshao mfshao approved these changes

@nmetokishlubsky nmetokishlubsky Awaiting requested review from nmetokishlubsky nmetokishlubsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocshawn @craigrbarnes @mfshao