Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GFF-223): Implement Cohort Discovery Start Page #303

Open
wants to merge 2 commits into
base: GFF-164_cohort_discovery_app_page
Choose a base branch
from
Open

(GFF-223): Implement Cohort Discovery Start Page #303

wants to merge 2 commits into from

Conversation

ocshawn
Copy link
Contributor

@ocshawn ocshawn commented Jan 14, 2025 •
edited
Loading

Link to JIRA ticket if there is one: GFF-223 GFF-224

New Features

  • Implement Cohort Discovery Start Page
  • Implement Cohort Discovery Left Side Navigation Panel

Improvements

  • style updates and added H1 title TODO make a config value
  • add global H1 style so its the same on all pages

craigrbarnes
craigrbarnes previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@craigrbarnes craigrbarnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The start page is fine, and thanks for adding to the configuration

@craigrbarnes craigrbarnes dismissed their stale review January 15, 2025 21:25

Did note Draft state

@ocshawn ocshawn marked this pull request as ready for review January 16, 2025 21:29
@ocshawn ocshawn requested a review from craigrbarnes January 16, 2025 21:29
@ocshawn
Copy link
Contributor Author

ocshawn commented Jan 16, 2025

ready for review now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigrbarnes craigrbarnes Awaiting requested review from craigrbarnes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocshawn @craigrbarnes