PPS-1617 Dependency update #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Avantol13
reviewed
Nov 4, 2024
pyproject.toml
Outdated
| @@ -7,7 +7,7 @@ license = "Apache-2.0" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.9" | |||
| fastapi = "^0.65.2" | |||
| fastapi = "<1" | |||
There was a problem hiding this comment.
let's just do "*" or >=0.65.2. attempt a potential major version upgrade
Avantol13
reviewed
Nov 4, 2024
| ).raise_for_status() | ||
| res = client.post(f"/metadata/{guid}/aliases", json={"aliases": aliases}) | ||
| if aliases is None: | ||
| with pytest.raises(httpx.HTTPStatusError, match="422 Unprocessable Entity"): |
There was a problem hiding this comment.
remind me why we're only raising if aliases is None?
There was a problem hiding this comment.
The endpoint expects a list, with the new version of fastapi the request returns a 422 when the value is None. The other values are lists so they're fine
Please find the detailed integration test report here Please find the ci env pod logs here |
Avantol13
approved these changes
Nov 5, 2024
matthewwest55
pushed a commit
to matthewwest55/metadata-service
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PPS-1617
Dependency updates