Feat/al2 updates #421
Open
Feat/al2 updates #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Avantol13
reviewed
Oct 23, 2024
deployment/wsgi/gunicorn.conf.py
Outdated
|
|
||
|
|
||
| def pre_fork(server, worker): | ||
| time.sleep(random.uniform(0, 2)) |
There was a problem hiding this comment.
can we add some comments about the reasoning for this? And is there a reason we do this here but not in other services like indexd?
Avantol13
reviewed
Oct 23, 2024
pyproject.toml
Outdated
| requests = ">=2.31.0,<3.0.0" | ||
| simplejson = ">=3.8.1" | ||
| sqlalchemy = ">=1.3.*" | ||
| cdispyutils = ">=2.0.1" | ||
| psqlgraph = ">=3.0.1" | ||
| cdiserrors = ">=1.0.0" | ||
| cdislogging = ">=1.0.0" | ||
| gen3dictionary = ">=2.0.3" | ||
| gen3datamodel = ">=3.1.0" | ||
| gen3dictionary = {git = "https://github.com/uc-cdis/datadictionary.git", branch = "chore/add-unit-tests"} |
There was a problem hiding this comment.
this needs to move off the branch
Avantol13
reviewed
Oct 23, 2024
Pull Request Test Coverage Report for Build 12815793702Details
💛 - Coveralls |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
…ng to install via yum slightly differently
Please find the detailed integration test report here Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
adding gunicorn and nginx to sheepdog and basing off our new secure python image