Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes score screen errors when linked from profile #14

Merged
merged 1 commit into from
Oct 12, 2018
Merged

fixes score screen errors when linked from profile #14

merged 1 commit into from
Oct 12, 2018

Conversation

iturgeon
Copy link
Member

@iturgeon iturgeon commented Sep 26, 2018 •
edited
Loading

solves #13

iturgeon
iturgeon commented Sep 26, 2018
View reviewed changes
src/js/controllers/ctrl-scores.js
@@ -192,21 +191,22 @@ app.controller('scorePageController', function(Please, $scope, $q, $timeout, wid
// get the current attempt from the url
const hash = getAttemptNumberFromHash()
if (currentAttempt === hash) {
return
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would prevent the promise from resolving, causing _getScoreDetails()->then() to not exist

iturgeon
iturgeon commented Sep 26, 2018
View reviewed changes
src/js/controllers/ctrl-scores.js
@@ -563,9 +563,9 @@ app.controller('scorePageController', function(Please, $scope, $q, $timeout, wid
}

const getAttemptNumberFromHash = () => {
const hashStr = window.location.hash.split('-')[1]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can match things it shouldn't

@clpetersonucf clpetersonucf changed the base branch from master to dev/0.3.6 October 3, 2018 14:10
@iturgeon iturgeon added the ready for qa Testing and feedback is requested label Oct 9, 2018
@iturgeon iturgeon merged commit da231f7 into dev/0.3.6 Oct 12, 2018
@iturgeon iturgeon deleted the issue/13-score-screen-with-play-id-hash-fails branch October 12, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for qa Testing and feedback is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iturgeon