Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new catalog updates needed to deal with empty meta_data #59

Conversation

iturgeon
Copy link
Member

extra robustness for widget catalog controller and tests

  • tests are more isolated
  • removed a lot of deps from tests
  • added a lot of isolated test cases
  • controller got a little more consistant at changing states

resolves #58

meta_data.features and meta_data.supported_data being null cause display issues
tests are more isolated
removed a lot of deps from tests
added a lot of isolated test cases
controller got a little more consistant at changing states
@iturgeon iturgeon added the ready for qa Testing and feedback is requested label May 15, 2019
@iturgeon iturgeon requested a review from a team May 15, 2019 23:38
clpetersonucf
clpetersonucf previously approved these changes May 24, 2019
Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working, LGTM

@iturgeon iturgeon merged commit 9409249 into ucfopen:dev/1.3.0 May 24, 2019
@iturgeon iturgeon deleted the issue/58-new-catalog-dealing-with-empty-meta_data branch May 24, 2019 22:01
@clpetersonucf clpetersonucf mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Testing and feedback is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants