Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/2.1.0 #74

Merged
merged 46 commits into from
Aug 23, 2019
Merged

Dev/2.1.0 #74

merged 46 commits into from
Aug 23, 2019

Conversation

clpetersonucf
Copy link
Member

@clpetersonucf clpetersonucf commented Jul 19, 2019

weining-li and others added 30 commits June 26, 2019 09:19
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.14)

Signed-off-by: dependabot[bot] <[email protected]>
…on-level

issue/1158 - default collaboration level
…17.14

Bump lodash from 4.17.11 to 4.17.14
…property

#1243 TypeError: Cannot set property 'checked' of undefined when selecting export options on widget with no scores
#1129 lti picker doesn't handle long titles
@clpetersonucf clpetersonucf marked this pull request as ready for review August 1, 2019 20:11
@clpetersonucf
Copy link
Member Author

Ready for review.

@clpetersonucf
Copy link
Member Author

This one looks good to me, tested on QA in conjunction with the dev/6 branch and everything works. Needs approval.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some potential issues in the LTI picker that could stand to be resolved, but they're outside the scope of these changes and can get their own issue.

Everything here looks like it's functioning well.

iturgeon
iturgeon previously approved these changes Aug 14, 2019
@iturgeon
Copy link
Member

iturgeon commented Aug 14, 2019

All looks good, though I have feedback on ucfopen/Materia#1245 that'll apply here

@clpetersonucf clpetersonucf merged commit b5f53fa into master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants