Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility edits #40
Accessibility edits #40
Changes from 16 commits
cbd478d
1003556
3fa8449
bb8a955
a6e1753
3d6b377
89744e0
5f19fbf
f4e9a8e
91d61d6
2100782
4e870e8
6b64b52
edd4cbf
0122769
8d87e86
b7d568c
72a0a44
986b40a
aa42133
d207875
0ce4715
49a3189
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines were not causing any sort of console of behavioral failure, so they got overlooked when I reviewed your changes previously, but FYI this is not how you assign attributes to DOM elements in JS. Even though
helpModal
is referencing a DOM element object, attributes must be set (or removed) via thesetAttribute
orremoveAttribute
methods, like so:Bear in mind that
inert
doesn't require a value, so the mere existence of the attribute means theinert
behavior will be applied. Therefore,helpModal.setAttribute('inert', 'false')
wouldn't work to disable it. The attribute has to be removed completely withremoveAttribute
. This change will need to be applied on all lines that are trying to set or remove theinert
attribute.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is still improperly trying to set the
inert
property on the DOM object directly, instead of usingsetAttribute()
. It's causing the test suite to fail. Always remember to runyarn test
before committing!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function appears to be causing the "___ of 5 remaining" issue. It resets the
completePerPage
array before refilling it using the matches each time a match is made. It would need another loop that finds pages with no matches, and sets those pages' counts to 0 in thecompletePerPage
array.The more efficient method may be to just replace the call to
_updateCompletionStatus
with$scope.completePerPage[$scope.currentPage]++
inside_pushMatch
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!