added some scripts for future use? #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2dev2
requested changes
Mar 30, 2024
data/scripts/update_members.sh
Outdated
Comment on lines
8
to
9
| npm install -g typescript | ||
| tsc "$new" |
There was a problem hiding this comment.
Don't need this, just use npm run tsc instead of tsc (the website already lists typescript as a dependency)
There was a problem hiding this comment.
this didn't work either, but somehow just tsc without the former line worked. I added this in the next commit, but make sure it is correct?
There was a problem hiding this comment.
tsc worked because you already had it globally installed on your system. It's a bit unexpected that npm run tsc didn't work, but I locally confirmed that yarn tsc actually works. Can you change to that?
r2dev2
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts to ease addition of new members into our website
make sure there isn't anything bad here