Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed archive card overflow overflow #166

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fixed archive card overflow overflow #166

merged 2 commits into from
Apr 22, 2024

Conversation

AVDestroyer
Copy link
Contributor

@AVDestroyer AVDestroyer commented Apr 20, 2024

For #142

for some reason this doesnt work with yarn build and yarn start but it does with yarn run dev??

all i changed was some css but hopefully its ok it looks good when it works.

- for some reason this doesn't work with `yarn build` but does with
  `yarn run dev`???
@AVDestroyer AVDestroyer linked an issue Apr 20, 2024 that may be closed by this pull request
@AVDestroyer AVDestroyer changed the title fixed archive card overflow error (#142) fixed archive card overflow overflow Apr 20, 2024
@AVDestroyer
Copy link
Contributor Author

also fixes #128 lol

@AVDestroyer AVDestroyer linked an issue Apr 20, 2024 that may be closed by this pull request
@bliutech bliutech self-requested a review April 20, 2024 19:06
Copy link
Member

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. Nice changes!

Letting @Arc-blroth double check before merging just in case of build issues.

Copy link
Member

@Arc-blroth Arc-blroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Arc-blroth Arc-blroth merged commit 4ea34ee into main Apr 22, 2024
@AVDestroyer AVDestroyer deleted the fix-card-overflow branch April 24, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cards Overflowing with Long Title fix: /events + /archive Card Ratios
3 participants