Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete to db/schema/event.js #34

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

seijiotsu
Copy link
Contributor

Issue #20 seemed to ask only for creating the column in the database. I'm not super familiar with Sequelize but I tried adding a delete column to the event schema. I think what's required after this is:

  • updating GET api/v1/event/past and GET api/v1/event/future and GET api/v1/event/:uuid? to only return events where deleted = false
  • updating DELETE api/v1/event/:uuid? to set deleted = true
  • don't change PATCH api/v1/event/:uuid?, but still allow people to manually use it to toggle deleted in case they want to undelete events
  • migrate existing events to the new schema? I read a little bit about how to do that, I'm not familiar with how the production database works so I assume someone else could take care of this.

but I'm not sure, so please clarify if I'm wrong. I'm not very familiar with the codebase so it's possible I edited the completely wrong thing.

@howardwang15
Copy link
Contributor

Ya this looks perfect

Copy link
Contributor

@howardwang15 howardwang15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@howardwang15 howardwang15 merged commit 829683a into master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants