Re-add compatibility with RV32 NOMMU #32
Conversation
who authored this originally ? you set the git commit to yourself. |
|
The trees diverged over time, I had to make the mods originally by @regymm (Yimin Gu) from an old version. But the patch itself is no longer apply-able. That's why I made a new one. |
|
if @regymm is the original author, and you've rebased their patch to apply to the latest tree, then imo the git author field should be set to them as the original person. |
|
I don't know what you would like etiquette wise, I just force pushed what I think is best? |
|
(Please review based off of 9466b11 ) |
|
are you basing the work off this patch ? |
|
Is there any further hold ups here? |
|
Looks fine to me! |
Allow elf2flt to work with RISC-V 32-bit targets. With these changes, the uclibc toolchain and busybox can work fine for rv32 no MMU systems with no noticable problem. Signed-off-by: Jesse Taube <[email protected]> [Add more ELF relco types and edit commit message] Signed-off-by: Yimin Gu <[email protected]>
|
i cleaned up the commit message to reflect the original patch @cnlohr we can add your s-o-b tag with credit for the rebase, but you don't seem to have a name listed |
|
Please do add your names! You've contributed more than me on this. |
|
Feel free! I'm either "cnlohr [email protected]" or "Charles Lohr [email protected]" I don't understand what the s-o-b field really is for, in that I don't have any authority within this project to sign anything off. I don't need credit but I am always willing to accept it :-p @vapier are any actions needed from me? Or is it something you would do on your end? I really struggle with figuring out how to directly "edit" commits for PRs, could you help me learn the workflow for that? |
|
the s-o-b tag is just saying "i have the authority to contribute this code under the project's license, and i don't have any random organizations (employers/companies) who would disagree & claim the work as their own". i've pushed this now, so there's nothing left to do. thanks all. |
Apply Yimin Gu's fixes to elf2flt to allow riscv 32 to use the same relocation mechansims as riscv 64.
Original copy was passed around the buildroot list, but, it would be helpful for this to be upstream.
You can see the original patch here:
5330503
It looks like the change was stomped in a merge.