Networking Setup / Lobby Discovery #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point I must have accidentally copy pasted something with tab indentations, so randomly throughout the repo there were files with tab indents instead of 4 space indents. Hopefully I found everywhere where this occurs.
… using cross-platform std::filesystem library.
… works on localhost)
Tyler-Lentz
changed the title
I figured out why everything is broken. It is because i was not considering the lifetimes of the buffers that I was passing to write/read calls. I need to go back through and refactor it taking this into account, making sure no vars go out of scope. Another Rust W.
…ssly broken. Last commit before I drop the approach
10 tasks
…ket to Server, but for some reason Server packet to Client not heard?
Also rearranged some of the client code slightly.
Gtest networking merge
Tyler-Lentz
requested review from
gilkeidar,
jhparkt,
atar13 and
EddieJ03
and removed request for
EddieJ03
EddieJ03
approved these changes
Apr 17, 2024
HUGE! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
This PR
Client,Server,Session,Event, andPacketclassesThe main interface exposed by the networking code is that of the Session class. The session class lets you send events to the server/client the session is connected to, and it also lets you read events that come in from the other direction.
I also had to make a bunch of random smaller changes to GameState to make everything interop with the networking code. Hopefully those are all okay.