Maze Environment Loading From File #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are stored in the `maps` directory)
…made the grid cell width a bit larger
… 2x2x2) and pulled new dev contents
atar13
approved these changes
May 5, 2024
include/server/game/constants.hpp
Outdated
| #define MAX_NUM_BASE_OBJECTS 100 | ||
| /* Maze Constants */ | ||
| #define MAZE_DIRECTORY "maps" | ||
| #define DEFAULT_MAZE_FILE "tyler_test.maze" |
There was a problem hiding this comment.
This could be nice to move into our config.json at the root of the repo with the other server setup stuff so that we don't have to recompile the server when the map changes.
There was a problem hiding this comment.
I updated the code to reflect this - please let me know if it works well on your end and if the new code looks alright!
There was a problem hiding this comment.
Works great on my end! Able to change maps without recompiling. Thanks for adding this feature!
src/client/client.cpp
Outdated
Comment on lines
224
to
227
| std::cout << "shared object " << i << ": position: " << glm::to_string(sharedObject->physics.position) << std::endl; | ||
|
|
||
| if (sharedObject == nullptr) | ||
| continue; |
There was a problem hiding this comment.
nitpick: if we want to keep this position printout, maybe move to after checking if sharedObject == nullptr just in case
…can be changed without server recompilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented an initial version of loading of a maze environment from a file.
Maze files are assumed to be in the
mapsdirectory.Maze files may only contain the characters
.,@, or#(and new-lines and EOFs); each row must have the same number of columns.The
ServerGameStateconstructors now call one of the constructors which callsloadMaze()which opens the maze file for reading and intializes theServerGameState'sGridinstance which encapsulates a 2-D vector ofGridCells, each of which corresponds to a character in the input maze file.After the
Gridis initialized inloadMaze(),loadMaze()iterates over all of theGridCells and placesSolidSurfaceobjects for each wall in the maze as well as a floor and ceilingSolidSurfacethat cover the entire maze.