Feature: Import new name fields for GRLN compliance #9
Conversation
…at LDAP/Connection is not a resource type.
…isplay name. Test passed.
…pped because of incorrect dependent test name.
…ppings stuff. Updated tests.
|
Tests related to the new changes are passing. We will fix the other code check tests in a separate ticket. |
| // Fixing: this field could have 'question mark' in it. | ||
| // If so, just remove it. ($DB->execute() does not like '?') | ||
| // Fixing: these fields could have 'question mark' in it. | ||
| // If so, just remove it. ($DB->execute() does not like '?'). |
There was a problem hiding this comment.
turns out that's by design. for reference: see https://moodle.org/mod/forum/discuss.php?d=173498
my takeaway is that $DB->execute() should be avoided, if possible.
There was a problem hiding this comment.
Created #10 for this._
I don't see any tests running in the CI. https://github.com/ucsf-education/moodle-admin-tool-ldapsync/actions/runs/8603199986/job/23574542617 |
| @@ -49,52 +50,109 @@ class tool_ldapsync_importer_testcase extends advanced_testcase { | |||
| private $sync = null; | |||
|
|
|||
| protected function setUp(): void { | |||
| // Create new empty test container. | |||
| $topdn = 'dc=moodletest,' . TEST_TOOL_LDAPSYNC_DOMAIN; | |||
There was a problem hiding this comment.
I don't see TEST_TOOL_LDAPSYNC_DOMAIN declared anywhere. same goes for the various other TEST_TOOL_ constants.
Ready for code review.