Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Moodle 4.4 version of the Ilios enrollment plugin. #105

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt marked this pull request as ready for review October 29, 2024 17:07
@ctam
Copy link

ctam commented Oct 30, 2024

@stopfstedt, would you enable GHA on your fork, so the tests will run there? I'd like to make sure the tests are green before approving. Thanks!

@stopfstedt stopfstedt force-pushed the moodle4.4_add_enrol_ilios_2024102900 branch 3 times, most recently from 7047d10 to 0e55fd0 Compare October 31, 2024 23:30
@stopfstedt
Copy link
Member Author

stopfstedt commented Nov 1, 2024

i removed the closure that was causing misleading output in an unrelated test failure, tests are currently running here:

https://github.com/stopfstedt/moodle/actions/runs/11621631040
https://github.com/stopfstedt/moodle/actions/runs/11621458278

for reference on the latest changes, please see ilios/moodle-enrol-ilios#64.

@stopfstedt stopfstedt marked this pull request as draft November 1, 2024 23:10
@stopfstedt
Copy link
Member Author

more changes incoming. turns out the bigger issue was closures coming in during object serialization of the enrollment object during testing.

see ilios/moodle-enrol-ilios#65 for details.

@stopfstedt stopfstedt force-pushed the moodle4.4_add_enrol_ilios_2024102900 branch from 0e55fd0 to 313da30 Compare November 1, 2024 23:30
@stopfstedt
Copy link
Member Author

test finally passed https://github.com/stopfstedt/moodle/actions/runs/11637794743

this is ready for integration.

@stopfstedt stopfstedt marked this pull request as ready for review November 2, 2024 01:26
Copy link

@ctam ctam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I resolved the merge conflict and moved the code block to alphabetical order.

@ctam ctam merged commit e73756f into ucsf-education:UCSFCLE_404_STABLE Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants