Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cwarwicker/moodle-tool_ribbons plugin with moodle_4.4 tag to admin/tool/ribbons as a submodule. #70

Conversation

ctam
Copy link

@ctam ctam commented Sep 19, 2024

See GHA here.


@ctam ctam self-assigned this Sep 19, 2024
@ctam ctam requested a review from a team September 19, 2024 23:16
@ctam
Copy link
Author

ctam commented Sep 20, 2024

GHA generated 11 errors here.

@stopfstedt stopfstedt requested review from stopfstedt and removed request for a team September 26, 2024 23:27
stopfstedt
stopfstedt previously approved these changes Sep 26, 2024
@stopfstedt stopfstedt self-requested a review September 26, 2024 23:29
@stopfstedt stopfstedt dismissed their stale review September 26, 2024 23:36

PR is still in draft mode, i reviewed too soon.

@stopfstedt stopfstedt requested review from a team and removed request for stopfstedt September 26, 2024 23:36
@stopfstedt
Copy link
Member

i had a look at the build errors, and there are two that are related to this plugin, but they appear several times

Debugging: Callback before_standard_html_head in tool_ribbons component should be migrated to new hook callback for core\hook\output\before_standard_head_html_generation

and

Debugging: Callback before_standard_top_of_body_html in tool_ribbons component should be migrated to new hook callback for core\hook\output\before_standard_top_of_body_html_generation

i see a clear upgrade path with minimal effort here, will put in a ticket and fix with the upstream maintainers. sit tight.

@stopfstedt
Copy link
Member

upstream ticket: cwarwicker/moodle-tool_ribbons#10

upstream pull request: cwarwicker/moodle-tool_ribbons#11

@stopfstedt
Copy link
Member

stopfstedt commented Sep 27, 2024

@ctam there's a new release of Ribbons as of this morning that includes the fix for these deprecation warnings.

https://github.com/cwarwicker/moodle-tool_ribbons/releases/tag/moodle_4.5

the new release tag is labeled moodle_4.5 edit: moodle_4.4

please update the PR, thanks.

@ctam ctam force-pushed the UCSFCLE_404-Add_cwarwicker/moodle-tool_ribbons_to_admin/tool/ribbons_as_a_submodule branch from 3d67327 to 81cadc8 Compare September 27, 2024 15:35
@ctam ctam marked this pull request as ready for review September 27, 2024 17:25
…dle-tool_ribbons_to_admin/tool/ribbons_as_a_submodule
@ctam
Copy link
Author

ctam commented Sep 27, 2024

Passed all GHA tests (here)[https://github.com/ctam/moodle/actions/runs/11073510331].

Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt changed the title Add cwarwicker/moodle-tool_ribbons plugin with v1.0.3 tag to admin/tool/ribbons as a submodule. Add cwarwicker/moodle-tool_ribbons plugin with moodle_4.4 tag to admin/tool/ribbons as a submodule. Sep 27, 2024
@ctam ctam merged commit e73be20 into ucsf-education:UCSFCLE_404_STABLE Sep 27, 2024
@ctam ctam deleted the UCSFCLE_404-Add_cwarwicker/moodle-tool_ribbons_to_admin/tool/ribbons_as_a_submodule branch September 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants