-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cwarwicker/moodle-tool_ribbons plugin with moodle_4.4 tag to admin/tool/ribbons as a submodule. #70
Conversation
GHA generated 11 errors here. |
PR is still in draft mode, i reviewed too soon.
i had a look at the build errors, and there are two that are related to this plugin, but they appear several times
and
i see a clear upgrade path with minimal effort here, will put in a ticket and fix with the upstream maintainers. sit tight. |
upstream ticket: cwarwicker/moodle-tool_ribbons#10 upstream pull request: cwarwicker/moodle-tool_ribbons#11 |
@ctam there's a new release of Ribbons as of this morning that includes the fix for these deprecation warnings. https://github.com/cwarwicker/moodle-tool_ribbons/releases/tag/moodle_4.5 the new release tag is labeled please update the PR, thanks. |
…ol/ribbons as a submodule.
3d67327
to
81cadc8
Compare
…dle-tool_ribbons_to_admin/tool/ribbons_as_a_submodule
Passed all GHA tests (here)[https://github.com/ctam/moodle/actions/runs/11073510331]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See GHA here.