Add ncstate-delta/moodle-mod_zoom with v5.2.4 tag to mod/zoom as a git submodule #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctam
commented
Oct 18, 2024
•
ctam
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208451304753727
- https://app.asana.com/0/0/1208571197277217
|
Inherited 12 PHPUnit test errors from the STABLE branch. |
ctam
force-pushed
the
UCSFCLE_404-Add_ncstate-delta/moodle-mod_zoom_as_a_submodule
branch
from
a6083ed
to
dfc8380
Compare
|
Rebased. Running tests here. |
ctam
force-pushed
the
UCSFCLE_404-Add_ncstate-delta/moodle-mod_zoom_as_a_submodule
branch
from
dfc8380
to
0ff137f
Compare
|
Re-ran Core / PHPUnit tests. All passed. Ready for review. |
|
Hey @mirleu, could you do another review and merge it if it looks good to you? Thanks! |
@ctam I approved but there seems to be conflicts and it's not allowing me to merge. |
…moodle-mod_zoom_as_a_submodule
I resolved the conflict but now tests are running again. @ctam @mirleu your call on when to merge. I should note that I did not put the submodules in order when resolving the conflict. |
mirleu
merged commit 20f6dce
into
ucsf-education:UCSFCLE_404_STABLE
1 of 2 checks passed
ctam
deleted the
UCSFCLE_404-Add_ncstate-delta/moodle-mod_zoom_as_a_submodule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.