fix

udecode · Jan 22, 2025 · 528ace5 · 528ace5
1 parent 566ac85
commit 528ace5
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 5 deletions.
diff --git a/config/eslint/bases/jest.cjs b/config/eslint/bases/jest.cjs
@@ -22,11 +22,11 @@ module.exports = {
       files: filePatterns.test,
       plugins: ['jest', 'jest-formatting', 'testing-library', 'jest-dom'],
       rules: {
+        'jest/no-disabled-tests': 'off',
         '@typescript-eslint/ban-ts-comment': 'off',
         '@typescript-eslint/no-empty-function': 'off',
         '@typescript-eslint/no-explicit-any': 'off',
         '@typescript-eslint/no-non-null-assertion': 'off',
-        '@typescript-eslint/no-object-literal-type-assertion': 'off',
         'import/default': 'off',
         'import/namespace': 'off',
         'import/no-duplicates': 'off',

diff --git a/jest.config.cjs b/jest.config.cjs
@@ -61,7 +61,7 @@ module.exports = {
   },
   transformIgnorePatterns: [
     '/node_modules/(?!(' +
-      'lucide-react|cheerio|react-dnd|dnd-core|@react-dnd|react-dnd-html5-backend|react-tweet|unified' +
+      'cheerio|react-dnd|dnd-core|@react-dnd|react-dnd-html5-backend|react-tweet|unified' +
       '|remark-.*' +
       '|mdast-.*' +
       '|micromark.*' +

diff --git a/packages/media/src/react/placeholder/internal/utils.ts b/packages/media/src/react/placeholder/internal/utils.ts
@@ -86,5 +86,5 @@ function populateMaps(
 function extname(path: string) {
   const index = path.lastIndexOf('.');
 
-  return index < 0 ? '' : path.slice(Math.max(0, index));
+  return index === -1 ? '' : path.slice(Math.max(0, index));
 }
diff --git a/packages/selection/src/react/internal/api/shiftSelection.ts b/packages/selection/src/react/internal/api/shiftSelection.ts
@@ -44,7 +44,7 @@ export const shiftSelection = (
   // Find the anchor block within the current selection array.
   const anchorIndex = blocks.findIndex(([node]) => node.id === anchorId);
 
-  if (anchorIndex < 0) {
+  if (anchorIndex === -1) {
     // If anchor not found in the current selection, fallback:
     setOption('anchorId', bottomNode.id);
 

diff --git a/packages/selection/src/react/transforms/setBlockSelectionNodes.ts b/packages/selection/src/react/transforms/setBlockSelectionNodes.ts
@@ -43,7 +43,7 @@ export const setBlockSelectionIndent = (
       const currentIndent = prevIndent + indent;
 
       editor.tf.setNodes(
-        { indent: currentIndent < 0 ? 0 : currentIndent },
+        { indent: Math.max(currentIndent, 0) },
         {
           ...options,
           at: path,

diff --git a/scripts/setupTests.ts b/scripts/setupTests.ts
@@ -18,3 +18,21 @@ jest.mock('@udecode/plate-core', () => ({
   __esModule: true,
   ...jest.requireActual('@udecode/plate-core'),
 }));
+
+// Add mock for lucide-react
+jest.mock('lucide-react', () => {
+  return new Proxy(
+    {
+      __esModule: true,
+    },
+    {
+      get: function (_, prop) {
+        if (prop === '__esModule') return true;
+        // Return a mock component for any icon request
+        return function MockIcon() {
+          return null;
+        };
+      },
+    }
+  );
+});