-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single step oro & fix files generation procedure for atm and ocn res combo #830
Merged
GeorgeGayno-NOAA
merged 92 commits into
ufs-community:develop
from
sanatcumar:single_step
Dec 12, 2023
Merged
Changes from 81 commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
f9e63a3
Add logic to ignore soil and clay percentage records.
GeorgeGayno-NOAA 26eeef1
Merge branch 'develop' into bugfix/bnu_soil
GeorgeGayno-NOAA ecf2442
Update documentation and script logs for new files.
GeorgeGayno-NOAA 478fbde
updates done by Sanatcumar
sanatcumar b91b5eb
updates done by Sanatcumar
sanatcumar 6a004a7
updates done by Sanatcumar
sanatcumar 9d1be51
updates done by Sanatcumar
sanatcumar d386999
updates done by Sanatcumar
sanatcumar e34c7d0
updates done by Sanatcumar
sanatcumar 2653ab2
updates done by Sanatcumar
sanatcumar 34a8676
Removed emails and links
sanatcumar cbb553f
Removed input files
sanatcumar 6a7b778
Removed input files
sanatcumar 0b9a03e
Removed log files
sanatcumar d6221b3
fixed the typo in ocean merge paths
sanatcumar 4a208a1
added explanatory comments as recomended to the ocean_merge routines
sanatcumar 069d1bf
removed unnecessary libraries (sp) when compiling
sanatcumar 41f87d6
fixed a broken path in ocean_merge
sanatcumar ab1e628
fixed a broken path to mosaic
sanatcumar 24c93fa
removed logs
sanatcumar eb0a511
relocated readme, reorganized output directories, removed logs and ot…
sanatcumar 65d34fa
added more explanatory comments to code
sanatcumar b74ebc8
Major revision split orog
sanatcumar 4455d90
Major revision split orog
sanatcumar e700e0a
Removed logs
sanatcumar f4769f8
removed some old namelist files
sanatcumar 400cc13
Merge branch 'develop' into bugfix/bnu_soil
GeorgeGayno-NOAA 084d51c
Some script updates.
GeorgeGayno-NOAA c246ffc
included doxygen(TNX George)+ set ocn default
sanatcumar e0d86d3
updated fv3gfs_driver_grid.sh comments to the correct sequence of calls
sanatcumar 2c9b502
updated fv3gfs_driver_grid.sh comments to the correct sequence of calls
sanatcumar 98caf8b
Update orion driver script to use additional resources
GeorgeGayno-NOAA 6179b24
Update jet grid driver script to request more resources
GeorgeGayno-NOAA fc17593
Minor updates to the wcoss2 driver grid script.
GeorgeGayno-NOAA 22dadfe
Merge branch 'develop' into bugfix/bnu_soil
GeorgeGayno-NOAA 6f3fe9e
Update some script comments. Update sfc_climo_gen script to use
GeorgeGayno-NOAA 64fdfd7
Update comments in the sfc_climo_gen utility script.
GeorgeGayno-NOAA 6e1c9b4
clean up before merge
sanatcumar df89e12
Update ccpp-physics submodule.
sanatcumar d4cfcc0
Update ccpp-physics
sanatcumar 1105547
Merge branch 'develop' into single_step
sanatcumar 05659d9
removed unnecessary files
sanatcumar 6b30462
fixed a gnu compile issue split the ocean merge into a driver and script
sanatcumar 4b3b25f
cleaned up the driver, fix gnu compile, split the ocean merge
sanatcumar 156bd27
Merge branch 'bugfix/bnu_soil' into single_step
sanatcumar 8284cbe
Cleaned up old directories and included print messages for debugging …
sanatcumar 0f60b72
fixed possible misleading errors in merge_lake_ochmsk.f90, fixed logi…
sanatcumar 36d6ec4
inlcudes a readme file for all options
sanatcumar 5dc234d
included logic to bypass when ocn is not set
sanatcumar ce8b596
Do not use the prev #.
sanatcumar 276f846
Now can run other grid type options as usual
sanatcumar 4769aea
Fixed issues with running other versions
sanatcumar df2420b
Updated the comments in the driver scripts
sanatcumar b24724f
updated origin and formated coments
sanatcumar 28f6ef4
Merge branch 'ufs-community:develop' into single_step
sanatcumar df0788d
Merge remote-tracking branch 'upstream/develop' into develop
sanatcumar 54b5564
Merge branch 'develop' into single_step
sanatcumar d0e2978
Modified the ocean merge and scriptto pass the binary_lake
sanatcumar eadcd71
Merge remote-tracking branch 'upstream/develop' into single_step
sanatcumar e2fbc56
changed the output file names to follow /scratch1/NCEPDEV/global/glop…
sanatcumar 13145aa
Fixed a typo in file name changes
sanatcumar e1c28f8
included the lake source data in the readme
sanatcumar 49b131d
fixed file names to run gsl suite
sanatcumar a0bfb00
Merge remote-tracking branch 'upstream/develop' into single_step
sanatcumar 1c53ea1
Included logic to work with different filenames
sanatcumar 6e18c0f
Fixed issues with nck commands with the new libaries from last PR
sanatcumar 76dd01a
Made filenames consistent
sanatcumar 2941924
Included creation date to readme
sanatcumar eb31490
Includes Mike's fix for coastal ORO issue
sanatcumar 7e64969
Includes Mike's coastal oro fix
sanatcumar 451d13c
Merge remote-tracking branch 'upstream/develop' into single_step
sanatcumar 5563ce4
tweaks to get the grid_gen test working
sanatcumar 29774b1
inlcuding lake source data for all gtypes
sanatcumar 10a3524
Merge remote-tracking branch 'upstream/develop' into single_step
sanatcumar 9977d8b
Tweaks to get gridgen tests working. Includes checking for uniform an…
sanatcumar 3151f77
includes Doxygen edits
sanatcumar 28a4cdb
Included newer variables in driver scripts for other machines
sanatcumar ccc72e3
Updated path for ocean merge files on orion
sanatcumar 291ba43
Includes logic by George to stop on error in the ocean merge routines
sanatcumar 07fdec3
Removed personal links except "ocean merge" and merged conflicts
sanatcumar c11ddcf
Changes to test the new location for ocean masks
sanatcumar cefff38
testing with new fix locations
sanatcumar 58da591
edited driver scripts for each machine
sanatcumar 5dcb766
Tweaks to make it run with the new soft linked orog
sanatcumar 2b362b5
Cleaned up unused variables
sanatcumar 30e2834
Cleaning up the unnecessary changes to use the fix files
sanatcumar a2082c0
Tweaks recomended by George to read long filenames
sanatcumar 2f2cb70
Reverted non relevant edits for this PR and removed a personal link
sanatcumar 27532c9
Removed personal link in readme
sanatcumar d5c01f6
Includes edits by george to grid_gen tests to accomodate the change f…
sanatcumar 9d60740
Tweaks to inlcude the hash automatically in the readme file. Nice ide…
sanatcumar d0d1e8f
last edits to sfc_gen
sanatcumar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
# $2+ - Executable and its arguments | ||
# | ||
|
||
ACCOUNT=gsd-fv3 | ||
ACCOUNT=fv3-cpu | ||
QOS=debug | ||
|
||
NP=$1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
list(APPEND fortran_src | ||
merge_lake_ocnmsk.f90 | ||
) | ||
|
||
if(CMAKE_Fortran_COMPILER_ID MATCHES "^(Intel)$") | ||
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -r8 -i4 -convert big_endian") | ||
elseif(CMAKE_Fortran_COMPILER_ID MATCHES "^(GNU)$") | ||
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fdefault-real-8") | ||
if(CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10) | ||
set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fallow-argument-mismatch") | ||
endif() | ||
endif() | ||
|
||
set(exe_name ocean_merge) | ||
add_executable(${exe_name} ${fortran_src}) | ||
target_link_libraries( | ||
${exe_name} | ||
|
||
NetCDF::NetCDF_Fortran) | ||
GeorgeGayno-NOAA marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
install(TARGETS ${exe_name}) | ||
|
||
# If doxygen documentation we enabled, build it. | ||
if(ENABLE_DOCS) | ||
add_subdirectory(docs) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# This is the CMake file for building this docs directory. | ||
# | ||
# Ed Hartnett 3/9/21 | ||
|
||
# Create doxyfile. | ||
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/Doxyfile.in ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile @ONLY) | ||
|
||
# Build documentation with target all. | ||
add_custom_target(ocean_merge_doc ALL | ||
${DOXYGEN_EXECUTABLE} ${CMAKE_CURRENT_BINARY_DIR}/Doxyfile | ||
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} | ||
COMMENT "Generating API Documentation with Doxygen" VERBATIM) | ||
|
||
# Ensure top-level docs have been generated. | ||
add_dependencies(ocean_merge_doc doc) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would set ocean_mask_dir in fv3gfs_driver_grid.sh using the $home_dir variable to set the path. Then, you don't need to declare it in every machine's driver script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @GeorgeGayno-NOAA ,$home_dir))/fix/orog/C$ {res}/ocean_mask/${ocn}/""
I had to use dirname in /ush/fv3gfs_ocean_merge.sh as the fortran merge code could not handle the "../" relative paths.
ocean_mask_dir="$(dirname $(dirname
It works now. But is there a better solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try this:
Update
fv3gfs_ocean_merge.sh
as follows:and
merge_lake_ocnmsk.f90
as followsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked. Thanks @GeorgeGayno-NOAA