Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize ATM-OCN resolutions for mapped ocean mask generation #993

Conversation

DeniseWorthen
Copy link
Contributor

@DeniseWorthen DeniseWorthen commented Oct 17, 2024

DESCRIPTION OF CHANGES:

The cpld_gridgen code is updated to loop over 6 ATM resolutions (C48, C96, C100, C384, C768 and C1152) and produce the mapped ocean mask for a given OCN resolution. Previously the only supported combinations were C48+5deg ocean, C96+1deg ocean, C192+1/2deg ocean and C384+1/4deg ocean.

The cpld_gridgen regression test scripts were also updated for the new feature.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using 91a0788.
  • Compile branch on Hera using GNU. Done using 91a0788.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Cactus using 91a0788.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using 91a0788.
  • Run relevant cpld_gridgen tests locally on all Tier 1 machines. All tests successful using 91a0788.

Describe any additional tests performed.

This PR adds additional mapped ocean mask files which were not previously generated. Baselines on Hercules-intel and Hera-intel were B4B for the existing mapped ocean mask files. For example, C192.mx050.tile[1-6].nc currently exists and are B4B with the baseline. C[1152, 768, 384, 96, 48].mx050.tile[1-6].nc do not currently exist and are now generated.

DOCUMENTATION:

A minor documentation update is added.

The Doxygen was built on Cactus using 91a0788. The cpld_gridgen section had no warnings.

ISSUE:

* update cpld_gridgen code to loop over all ATM resolutions and
produce the mapped ocean mask for a given OCN resolution
* update regression test scripts for cpld_gridgen
@DeniseWorthen
Copy link
Contributor Author

@GeorgeGayno-NOAA I see some recent commits that allowed building on Gaea5/6, but we are not yet maintaining baselines there. Is that correct?

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA I see some recent commits that allowed building on Gaea5/6, but we are not yet maintaining baselines there. Is that correct?

Correct. Gaea is not officially supported. I don't even have access to that machine. Don't worry about that machine.

@DeniseWorthen
Copy link
Contributor Author

I've created and verified baselines on Hera, Hercules and Orion.

hera: /scratch1/NCEPDEV/stmp4/Denise.Worthen/CPLD_GRIDGEN/BASELINE
hercules: /work2/noaa/stmp/dworthen/CPLD_GRIDGEN/BASELINE
orion: /work/noaa/stmp/dworthen/CPLD_GRIDGEN/BASELINE

Jet is just sitting in the Q, and I need to get my WCOSS2 reactivated before running there. I'll update you when I get those two ready.

@GeorgeGayno-NOAA
Copy link
Collaborator

I've created and verified baselines on Hera, Hercules and Orion.

hera: /scratch1/NCEPDEV/stmp4/Denise.Worthen/CPLD_GRIDGEN/BASELINE hercules: /work2/noaa/stmp/dworthen/CPLD_GRIDGEN/BASELINE orion: /work/noaa/stmp/dworthen/CPLD_GRIDGEN/BASELINE

Jet is just sitting in the Q, and I need to get my WCOSS2 reactivated before running there. I'll update you when I get those two ready.

I will move your baseline files to the official location.

@DeniseWorthen
Copy link
Contributor Author

@GeorgeGayno-NOAA Just an update. I have not successfully been able to run on Jet yet. It is just sitting pending in the Q. I think UFS is having trouble getting anything through the Q on Jet. I'm working on getting WCOSS2 re-activated.

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA Just an update. I have not successfully been able to run on Jet yet. It is just sitting pending in the Q. I think UFS is having trouble getting anything through the Q on Jet. I'm working on getting WCOSS2 re-activated.

I can't get anything to run either (using the "hfv3gfs" project). I emailed the Jet help desk. Here is what they wrote:

The reason why "hfv3gfs" is experiencing long wait times is because Jet has high usage, and "hfv3gfs"'s current fairshare value is low.

Please see the following from a report from yesterday afternoon:

Project: hfv3gfs
----------------------
NormShares: 0.000693
FairShare: 0.000106
Rank: 46/48

Because "hfv3gfs" has a fairshare of "1% of 1%", and a rank of "46/48", the project has to wait to submit jobs when Jet is experiencing high usage.

I don't know what project you use, but you can check this info by typing "account_params".

@DeniseWorthen
Copy link
Contributor Author

DeniseWorthen commented Oct 22, 2024

@GeorgeGayno-NOAA I have a baseline on WCOSS2 now

/lfs/h2/emc/stmp/denise.worthen/CPLD_GRIDGEN/BASELINE

I use the h-nems account on Jet, but our fairshare is just as low there. Hopefully I'll get the baselines generated at some point.

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA I have a baseline on WCOSS2 now

/lfs/h2/emc/stmp/denise.worthen/CPLD_GRIDGEN/BASELINE

I use the h-nems account on Jet, but our fairshare is just as low there. Hopefully I'll get the baselines generated at some point.

If you think your tests can run in under 30 minutes, try the 'debug' queue. I am getting good turnaround with 'debug' this morning.

@DeniseWorthen
Copy link
Contributor Author

I'll try that, thanks.

Jet is so small, I don't understand why everyone wants to run there.

@DeniseWorthen
Copy link
Contributor Author

I was able to create a baseline on Jet using the debug Q

/lfs5/HFIP/h-nems/Denise.Worthen/CPLD_GRIDGEN/BASELINE

@DeniseWorthen DeniseWorthen marked this pull request as ready for review October 23, 2024 16:21
@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA I have a baseline on WCOSS2 now

/lfs/h2/emc/stmp/denise.worthen/CPLD_GRIDGEN/BASELINE

I use the h-nems account on Jet, but our fairshare is just as low there. Hopefully I'll get the baselines generated at some point.

Sorry, @DeniseWorthen - I got distracted. Can you regenerate your baseline on WCOSS2? Appologies.

@DeniseWorthen
Copy link
Contributor Author

No problem. I'll let you know when they're done.

@DeniseWorthen
Copy link
Contributor Author

I've regenerated WCOSS2 baselines

/lfs/h2/emc/stmp/denise.worthen/CPLD_GRIDGEN/BASELINE/

@GeorgeGayno-NOAA
Copy link
Collaborator

Thanks, @DeniseWorthen. Merging now.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit c134505 into ufs-community:develop Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generalize the combinations available for cpld_gridgen
2 participants