Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langmuir turbulence parameterization for WW3 #2188

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Mar 13, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Adds Langmuir turbulence parameterization from ESCOMP to allow computing Stokes drift diagnostics within the WW3 sub-component.

Commit Message:

Add Langmuir turbulence parameterization for computing Stokes drift diagnostics

  * WW3 - Langmuir turbulence parameterization

Priority:

  • Normal.

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

  • Updated input data.

(mod_def's have been updated for all RT's. Updated directory location: /scratch1/NCEPDEV/climate/Matthew.Masarik/waves/share/ufs/moddefs/WW3_input_data_20240214).

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@MatthewMasarik-NOAA
Copy link
Collaborator Author

MatthewMasarik-NOAA commented Mar 15, 2024

I'm going to close this draft PR in favor of opening a new one from a branch with a cleaned up commit history. I made a misstep somewhere along the way committing test_changes.list and syncing yesterday. Starting with a clean branch seemed preferable to me than trying to make fixes on top of this one.

@MatthewMasarik-NOAA
Copy link
Collaborator Author

MatthewMasarik-NOAA commented Mar 15, 2024

New draft pr: #2195

@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the feature/Langmuir-param branch March 26, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Langmuir parameterization to WW3
1 participant