Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 #2481 #2458

Merged
merged 17 commits into from
Nov 8, 2024
Merged

Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 #2481 #2458

merged 17 commits into from
Nov 8, 2024

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Oct 9, 2024 •
edited by jkbk2004
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Add several Intel LLVM test to rt.conf. A separate configuration file (rt_intelllvm.conf) is still in the repository and can be used to run a more complete list of intel test using the new compiler. But we decided to include small subset of those test in rt.conf so that we have at least few tests executed before each PR is merged.

On each of the 4 platforms that currently support llvm compiler (Hercules, Orion, Gaea and Hera) 2 tests were added.
The test_changes.list file is updated.

Commit Message:

* UFSWM - Enable some of the intel llvm tests in rt conf
* UFSWM - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables 
  * FV3 - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables
    * ccpp-physics - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables

Priority:

  • Normal

Git Tracking

UFSWM:

  • Closes #
  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DusanJovic-NOAA
Add several tests using Intel LLVM compiler to rt.conf
4b34267
@DusanJovic-NOAA
Update ufs_hercules.intelllvm.lua
6bb538b
@DusanJovic-NOAA
Update rt_intelllvm.conf
ec9ddbf
@DusanJovic-NOAA
Update test_changes.list
8a7609d
@DusanJovic-NOAA
Update ufs_orion.intelllvm.lua
9acdbd4
@DusanJovic-NOAA
Update ufs_gaea.intelllvm.lua
cc893d8
@DusanJovic-NOAA
Update ufs_hera.intelllvm.lua and do not run debug intel llvm tests o…
015c8b6 
…n Hera

Currently all debug intel llvm tests fail to build on Hera.
The build fails at linking with errors like:

ld: cannot find -lpioc
ld: attempted static link of dynamic object `/scratch1/NCEPDEV/nems/role.epic/spack-stack
/spack-stack-1.6.0/envs/unified-env-rocky8/install/intel/2021.5.0/netcdf-fortran-4.6.1-ifhqcwv/lib/libnetcdff.so'

or

ld: attempted static link of dynamic object `/apps/oneapi/compiler/2023.2.0/linux/compiler/lib/intel64_lin/libiomp5.so'
@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as draft October 9, 2024 13:42
@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as ready for review October 10, 2024 14:16
@jkbk2004 jkbk2004 mentioned this pull request Oct 22, 2024
Closed
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 5, 2024

@DusanJovic-NOAA wcoss2 is on maintenance this week. This RP requires adding intelllvm baselines on hercules/orion/gaea/hera. I think we can move on with this PR. #2481 is also no baseline change. Can you sync up and point to https://github.com/grantfirl/fv3atm/tree/rrfsv1-to-ufs/dev2? So we can test across RDHPCS.

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA wcoss2 is on maintenance this week. This RP requires adding intelllvm baselines on hercules/orion/gaea/hera. I think we can move on with this PR. #2481 is also no baseline change. Can you sync up and point to https://github.com/grantfirl/fv3atm/tree/rrfsv1-to-ufs/dev2? So we can test across RDHPCS.

I synced my branch. But https://github.com/grantfirl/fv3atm/tree/rrfsv1-to-ufs/dev2 should be first synced with develop.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 6, 2024

@DusanJovic-NOAA wcoss2 is on maintenance this week. This RP requires adding intelllvm baselines on hercules/orion/gaea/hera. I think we can move on with this PR. #2481 is also no baseline change. Can you sync up and point to https://github.com/grantfirl/fv3atm/tree/rrfsv1-to-ufs/dev2? So we can test across RDHPCS.

I synced my branch. But https://github.com/grantfirl/fv3atm/tree/rrfsv1-to-ufs/dev2 should be first synced with develop.

@DusanJovic-NOAA Grant is on leave. I synced up the fv3 branch: grantfirl/fv3atm@1947bad

@DusanJovic-NOAA
Copy link
Collaborator Author

This branch is updated to point to grantfirl/fv3atm@1947bad

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the New Baselines New baselines will be added to project. label Nov 6, 2024
@jkbk2004 jkbk2004 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Nov 6, 2024
@FernandoAndrade-NOAA FernandoAndrade-NOAA added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Nov 7, 2024
@jkbk2004 jkbk2004 changed the title Enable some of the intel llvm tests in rt conf Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 #2481 Nov 8, 2024
@jkbk2004 jkbk2004 mentioned this pull request Nov 8, 2024
Merged
@grantfirl grantfirl mentioned this pull request Nov 8, 2024
Closed
14 tasks
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 8, 2024

@DusanJovic-NOAA new fv3 hash is NOAA-EMC/fv3atm@4996725

@BrianCurtis-NOAA
Copy link
Collaborator

WCOSS2 downtime and sporadic Acorn access is why these machines have been skipped for this PR. Work will take place with these machines back to catch up,

@jkbk2004 jkbk2004 merged commit 058f073 into ufs-community:develop Nov 8, 2024
4 checks passed
@DusanJovic-NOAA DusanJovic-NOAA deleted the enable_llvm_tests_in_rt_conf branch November 12, 2024 14:24
tsga added a commit to tsga/ufs-weather-model that referenced this pull request Nov 13, 2024
@tsga
Merge branch 'develop' into feature/lnd_iau
00e041e 
* develop:
  Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + ufs-community#2459 (ufs-community#2461)
  Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458)
  Fix/cpld sfs rt + Pull in units updates from FV3 ufs-community#2467 (ufs-community#2475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa left review comments

@zach1221 zach1221 zach1221 approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

@FernandoAndrade-NOAA FernandoAndrade-NOAA Awaiting requested review from FernandoAndrade-NOAA

Assignees
No one assigned
Labels
New Baselines New baselines will be added to project. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DusanJovic-NOAA @jkbk2004 @BrianCurtis-NOAA @junwang-noaa @zach1221 @FernandoAndrade-NOAA