Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.1.0 #395

Closed
wants to merge 59 commits into from
Closed

release-1.1.0 #395

wants to merge 59 commits into from

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Jan 24, 2024

Merge develop -> main to create v1.1.0 release.

maddenp-noaa and others added 30 commits October 4, 2023 16:57
* First schema draft with one level, untested

* draft 1 to try recursion

* Combined multiple solutions

* preliminary test version

* ChatGPT corrections applied, still test error

* Comment added to test git actions

* Validator update from PR #291

* Updating to test invalid entry
Additional validator changes added

* Fixed time regex, looping, some errors
anyOf still overmatching

* Removed anyOf list and added datadep comprehension

* cleaned up rocoto.jsonschema merge

* Added missing requirements and patterns

* quick redundant requirement edit

* fixed 'some' tag

* Updated to match loop pattern of UW-381

* corrected placement of dependency to under task

* Updated to bring in like with UW-381
Still requires fail condition tests for dependency

* fix conflict resolution error

* Validation failure tests added

* added regex_logged()

* Update docs from #302 to fix ReadTheDocs

* Overriding jq -r to restore jsonschema

* Update to dependentSchemas and 2020 draft

* Fixed order standards in test_validator
Remove Jenkins CI config
CI publish fixes from main branch
Refactored FV3Forecast methods that create model_configure, namelist, and field table to make calls to the same private base function.
Updated doc strings in forecast driver to follow newer format.
Added cycle and date to input arguments for uw forecast run
Attempted to Clean the run() method.
Added a method that will set mpi variables before running the mpi command.
Add run job method to scheduler class.
Add dump method to BatchScript class
Updated the forecast schema to reflect the sections needed to "fully" configure a forecast. Caveat -- fully configure it for standalone regional use case.
…ven the rocoto native schema (#317)

* Start of CLI, need inline validation and tests

* updates to fix issues
Tests in progress
Will recheck file.py edits

* updates to testing

* add inline validation of input and output

* fixed tests and logic
reverted file.py changes

* Incorporating multiple suggestions
Pending rocoto.py edits and log handling

* added realize_rocoto_xml(), tests in progress

* Added verbose logging, tests in progress

* fixes done, need rocoto tests and paths

* Major suggestions added, fixing minor issues

* all 'as m' clarified to 'as module'

* fixed path handling

* Incorporating feedback and correcting validation
still need to fix coverage of invalid XML

* removed pragma, added temp output handling
note: coverage still an issue

* change naming from input_yaml to config_file

* Resolving feedback, still fixing coverage

* Fixing residual naming issues

* invalid_xml test coverage fixed

* fixed  importers to handle OptionalPath

* Docstrings fixed, investigating rocoto.jinja2

* Clarified schema vs template; current write error

* Fixed template and task handling return
Current test issue with passing over temp xml

* fixed tests

* Removed unnecessary declarations

* Several fixes; still an issue in rocoto.jinja2

* unpatched write
…nput and output (#324)

* Fix rocoto and jinja output calls to handle stream

* Fix required output; revert jinja to limit scope

* Restored changes to j2template

* missed save on import declaration

* Added recommended refactor of realize_rocoto_xml

* Adding additional feedback to fix validate
also, no longer have to __enter__ on mock

* Fix tests after merging; piping and redirect works

* Fixed test mock, added feedback of renaming

* reverting to etree.fromstring()

* Further simplified realize()
* added cli tests without optional args
_dict_from_key_eq_val_strings now can be optional

* tests now use parse_args, reverting None option

* removed test_cli use of STR.render for "render"

* merging fixed; translate/validate tests still fail

* tests fixed with hardcoded formats

* Removed use of _parse_args() from all cli tests

* fixed test typing
* added dry run to prepare directories

* added logging to prepare config files

* added prepare batch script method

* full command -> prepare & execute

* WIP, dry test failing

* from UW Group

* failing local execution test

* before-the-fact log messages

* updated tests

* updated run_cmd doc string

* updated var name

* fixed spelling

* doc string updates

* doc string changes
Co-authored-by: Naureen Bharwani <[email protected]>
* WIP

* rearranging functions

* typos and name changes

* simplify test

* adding definite articles

* found spelling mistakes
* WIP

* Factoring out taskdep [skip ci]

* taskdep working properly [skip ci]

* Added datadep tag

* Added timedep

* Added some operator str literals

* WIP on parametrization

* Updated test case for datadep and timedep

* Added reserved words to str literals

* Added strequality tags

* Added Boolean operators

* WIP on operators

* Updating true/false tags [skip ci]

* Removed true/false tags, updated schema [ci skip]

* Remove true/false tags from the schema [ci skip]

* Added offset tag in schema to timedep [ci skip]

* Undo changes to the Relax NG schema [ci skip]

* Removed offset attr from timedep in schema [ci skip]

* Fixed datadep and timedep tests

* Modified operator test case [ci skip]

* Removed TimePattern from schema

* Working on operators nested dict test [ci skip]

* Modified test case

* Modified task dependency method [ci skip]

* Modified methods/tests to look cleaner

* Added check for tag name

* Added docstrings to methods

* DRY out reusable variables

* Final cleanup

* Fixing formatting/linter issues

* Minor removals

* Reordering of methods/tests lexicographically

* Reordered methods/tests lexicographically

* Added return type annotation

* Reorder arguments

* Reordered docstr for block/tag

* Combined oeprator/operands

* Updated docstr
* Split bash handling to sh.py
Updated affected tests and config references
One fix in sh._load() remaining

* Updating test_base, currently failing

* Included several recommended changes, see notes
Formats now have _MAXDEPTH
split off two methods for ConfigParser dicts
updated test files
updated ini and sh logic
still solving failing tests

* tests fixed; does not convert to/from sh

* Feedback in consistency and thoroughness added
Need to resolve depths and types still

* Removed dump depth check, fixed DEPTH in formats

* removed unnecessary imports

* Refactored Config section handling
Removed additional uses of 'bash' where appropriate

* removed comprehensions

* fixed test_ini description error
maddenp-noaa and others added 23 commits December 6, 2023 10:52
…onfigs/files, allowing for positional arguments (#365)

* move dereference

* WIP

* tests passing

* positional arguments

* tests and typos

* update doc strings

* pluralize

* comment for HelpFormatter

* cornucopia of change

* remove '=None'

* remove '=None'

* revert
* fixing cli config validate

* change to input_file

* fix names in patching
Fixing a couple of issues when testing the forecast driver that needed to be addressed.
Documentation for the forecast driver. Also includes a couple of changes to code to be consistent with docs.
* updated testing coverage and errors

* update check naming to verbosity

* Fix merge errors and suggestions
stacktrace test currently fails

* moved catch to try block, updated test
test still failing

* updating fixed test and docs

* updated feedback and improved tests

* Update docs/sections/user_guide/cli/mode_config.rst

the the is unnecessary

Co-authored-by: Paul Madden <[email protected]>

* too many 'the'

* Fixed extra line, updated logging error message

---------

Co-authored-by: Paul Madden <[email protected]>
@maddenp-noaa maddenp-noaa self-assigned this Jan 24, 2024
maddenp-noaa and others added 3 commits January 24, 2024 16:44
commit 279e681
Author: Paul Madden <[email protected]>
Date:   Thu Oct 5 20:44:02 2023 +0000

    Hotfix: Try to locate ALL packages built by CI

commit 6f1c5fe
Author: Paul Madden <[email protected]>
Date:   Thu Oct 5 18:43:58 2023 +0000

    Install anaconda-client for CI jobs

commit beb0bf4
Author: Paul Madden <[email protected]>
Date:   Thu Oct 5 12:20:28 2023 -0600

    Release Test (#309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants