Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fv3-schema-update #405

Merged
merged 23 commits into from
Feb 7, 2024
Merged

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Jan 31, 2024

Synopsis

Updates to the FV3Forecast JSON Schema to try to track current code and documentation. Issues mentioned in UW-495 may still need to be addressed in the context of this PR.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Jan 31, 2024
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realizing with this PR that we will likely want to brainstorm soon-ish how to deal with the interaction of the requirements of various drivers with each other just as a forward thinking exercise.

Here, it becomes evident in the parts that limit entries of a given section like the preprocessing: lateral_boundary_conditions: block. We will likely want more than that to be able to communicate the needs of that driver, but these are the bare minimum needed to complete a regional atmospheric uncoupled forecast. I tried to point out those bits in particular that are related to this concept.

src/uwtools/resources/FV3Forecast.jsonschema Show resolved Hide resolved
src/uwtools/resources/FV3Forecast.jsonschema Show resolved Hide resolved
src/uwtools/resources/FV3Forecast.jsonschema Show resolved Hide resolved
src/uwtools/resources/FV3Forecast.jsonschema Show resolved Hide resolved
src/uwtools/resources/FV3Forecast.jsonschema Show resolved Hide resolved
src/uwtools/resources/FV3Forecast.jsonschema Outdated Show resolved Hide resolved
src/uwtools/resources/FV3Forecast.jsonschema Show resolved Hide resolved
@maddenp-noaa
Copy link
Contributor Author

maddenp-noaa commented Feb 6, 2024

config.txt
Here's a YAML config that passes validation given the schema as of this writing. Please let me know if you see any issues.

My current plan is: Once we think the schema and general semantics are ok, I'll

  1. Add more of the granular schema tests to shore up the FV3 schema, then
  2. Do a separate PR to update the RST docs where they're impacted by the changes in this PR, then
  3. Merge all of the in-progress graph-based-driver work and continue with that.

Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for sticking with me through several iterations, and owning getting this into decent shape.

@maddenp-noaa maddenp-noaa merged commit b8c2081 into ufs-community:main Feb 7, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the fv3-schema-update branch February 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants