Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-598 JEDI driver fix to provide a JEDI config in the run command. #505

Merged
merged 1 commit into from
Jun 10, 2024
Merged

UW-598 JEDI driver fix to provide a JEDI config in the run command. #505

merged 1 commit into from
Jun 10, 2024

Conversation

christinaholtNOAA
Copy link
Contributor

Synopsis

Fixes a bug in the JEDI driver where the jedi.yaml was not provided to the specified JEDI executable.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA added the bug Something isn't working label Jun 9, 2024
@christinaholtNOAA christinaholtNOAA self-assigned this Jun 9, 2024
NaureenBharwaniNOAA
NaureenBharwaniNOAA approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for this fix.

WeirAE
WeirAE approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great quick fix!

@christinaholtNOAA christinaholtNOAA changed the title JEDI driver fix to provide a JEDI config in the run command. UW-598 JEDI driver fix to provide a JEDI config in the run command. Jun 10, 2024
@christinaholtNOAA christinaholtNOAA merged commit f4f1ac1 into ufs-community:main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees

@christinaholtNOAA christinaholtNOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christinaholtNOAA @WeirAE @NaureenBharwaniNOAA @maddenp-noaa @elcarpenterNOAA