Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-589 Yield a requirement on base_file when used #507

Merged
merged 8 commits into from
Jun 11, 2024
Merged

UW-589 Yield a requirement on base_file when used #507

merged 8 commits into from
Jun 11, 2024

Conversation

maddenp-noaa
Copy link
Contributor

Synopsis

Update drivers that use base_file to yield a requirement on the specified file.

Type

  • Code maintenance (refactoring, etc. without behavior change)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Jun 11, 2024
maddenp-noaa
maddenp-noaa commented Jun 11, 2024
View reviewed changes
src/uwtools/drivers/chgres_cube.py Show resolved Hide resolved
src/uwtools/drivers/mpas.py Show resolved Hide resolved
src/uwtools/drivers/mpas_init.py Show resolved Hide resolved
src/uwtools/drivers/ww3.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_chgres_cube.py Show resolved Hide resolved
src/uwtools/tests/drivers/test_chgres_cube.py Show resolved Hide resolved
src/uwtools/utils/tasks.py Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review June 11, 2024 19:10
elcarpenterNOAA
elcarpenterNOAA approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

WeirAE
WeirAE approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the DRYing out and LGTM!

@maddenp-noaa maddenp-noaa merged commit 3509e23 into ufs-community:main Jun 11, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the uw-589-base-file-required branch June 11, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddenp-noaa @WeirAE @NaureenBharwaniNOAA @elcarpenterNOAA