Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-391 Add IODA driver #511

Merged
merged 8 commits into from
Jun 18, 2024
Merged

UW-391 Add IODA driver #511

merged 8 commits into from
Jun 18, 2024

Conversation

christinaholtNOAA
Copy link
Contributor

Synopsis

Adds IODA driver, docs, and schema

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA self-assigned this Jun 17, 2024
christinaholtNOAA
christinaholtNOAA commented Jun 17, 2024
View reviewed changes
docs/Makefile Show resolved Hide resolved
docs/sections/user_guide/cli/drivers/ioda/help.out Outdated Show resolved Hide resolved
docs/shared/sfc_climo_gen.yaml Show resolved Hide resolved
src/uwtools/drivers/ioda.py Outdated Show resolved Hide resolved
NaureenBharwaniNOAA
NaureenBharwaniNOAA approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

docs/sections/user_guide/cli/drivers/ioda/help.out Outdated Show resolved Hide resolved
src/uwtools/resources/jsonschema/ioda.jsonschema Outdated Show resolved Hide resolved
src/uwtools/tests/drivers/test_ioda.py Outdated Show resolved Hide resolved
maddenp-noaa
maddenp-noaa reviewed Jun 18, 2024
View reviewed changes
docs/sections/user_guide/yaml/components/ioda.rst Outdated Show resolved Hide resolved
docs/shared/ioda.yaml Show resolved Hide resolved
docs/shared/ioda.yaml Show resolved Hide resolved
src/uwtools/drivers/ioda.py Outdated Show resolved Hide resolved
@christinaholtNOAA christinaholtNOAA merged commit 91b5dad into ufs-community:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@jprestop jprestop Awaiting requested review from jprestop

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

@WeirAE WeirAE Awaiting requested review from WeirAE WeirAE is a code owner

Assignees

@christinaholtNOAA christinaholtNOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christinaholtNOAA @NaureenBharwaniNOAA @maddenp-noaa