Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-626 Update developer_setup.rst documentation with IDE troubleshooting #513

Merged
merged 4 commits into from
Jun 20, 2024
Merged

UW-626 Update developer_setup.rst documentation with IDE troubleshooting #513

merged 4 commits into from
Jun 20, 2024

Conversation

lexbuko22
Copy link
Contributor

Synopsis

Added language for VS Code Python interpreter troubleshooting to the developer setup docs.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@lexbuko22
Update developer_setup.rst
f44967e 
Added language for VS Code Python interpreter troubleshooting.
WeirAE
WeirAE requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a good idea to add a little UW-specific text about our most common IDE here, so thanks! Just a technicality here and we can probably add more details later as well

docs/sections/contributor_guide/developer_setup.rst Outdated Show resolved Hide resolved
elcarpenterNOAA
elcarpenterNOAA approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

WeirAE
WeirAE approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christinaholtNOAA christinaholtNOAA merged commit e654f1d into ufs-community:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lexbuko22 @WeirAE @NaureenBharwaniNOAA @maddenp-noaa @elcarpenterNOAA @christinaholtNOAA