Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_dir -> rundir #520

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Jul 2, 2024

Synopsis

Replace UW YAML key run_dir with the simpler (and IMO more instinctive) rundir. There's nothing here but a simple replacement. All tests still pass, and no documentation needed to be updated. This will require existing UW YAML configs to update accordingly, but we're currently in the early days of integration and, if we want this change, should do it now.

EDIT: Also rename provisioned_run_directory() task method to provisioned_rundir().

Type

  • Code maintenance (refactoring, etc. without behavior change)

Impact

  • This is a breaking change (changes existing functionality)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Jul 2, 2024
@maddenp-noaa maddenp-noaa merged commit be951b6 into ufs-community:main Jul 3, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the run_dir-to-rundir branch July 3, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants