Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose driver base classes via API #523

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Expose driver base classes via API #523

merged 6 commits into from
Jul 9, 2024

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Jul 3, 2024 •
edited
Loading

Synopsis

#518 exposed component-driver classes via the uwtools API, but externally-developed coupled drivers will also need to access base driver classes (see #521) to inherit from and extend. This PR provides access.

Type

  • Enhancement (adds new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Jul 3, 2024
maddenp-noaa
maddenp-noaa commented Jul 9, 2024
View reviewed changes
src/uwtools/api/driver.py Show resolved Hide resolved
src/uwtools/drivers/ww3.py Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review July 9, 2024 14:38
christinaholtNOAA
christinaholtNOAA approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/uwtools/api/driver.py Show resolved Hide resolved
@maddenp-noaa maddenp-noaa merged commit 7c0a5a7 into ufs-community:main Jul 9, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the driver-base-classes-to-api branch July 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

@WeirAE WeirAE Awaiting requested review from WeirAE WeirAE is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddenp-noaa @christinaholtNOAA @NaureenBharwaniNOAA @elcarpenterNOAA