-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config realize bugfix #525
Merged
maddenp-noaa
merged 13 commits into
ufs-community:main
from
maddenp-noaa:config-realize-bugfix
Jul 11, 2024
Merged
Config realize bugfix #525
maddenp-noaa
merged 13 commits into
ufs-community:main
from
maddenp-noaa:config-realize-bugfix
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
commented
Jul 9, 2024
maddenp-noaa
requested review from
NaureenBharwaniNOAA,
christinaholtNOAA,
elcarpenterNOAA,
fgabelmannjr and
WeirAE
as code owners
July 10, 2024 14:53
elcarpenterNOAA
approved these changes
Jul 10, 2024
NaureenBharwaniNOAA
approved these changes
Jul 10, 2024
WeirAE
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Consider the following reasonable thing you might want to do via the
uwtools
API (in particular, this might be useful in a loop to apply multiple updates to a base config initially represented as adict
, after which aYAMLConfig
,NMLConfig
, etc. might be instantiated with this built-updict
to write the final config to disk in the desired format):Currently, this is the result:
This is due to a bug in how
realize_to_dict()
is implemented. While fixing the proximate bug, however, I discovered a few other updates needed to support operations on in-memorydict
objects, which I think will be a natural thing for API users to want to do. These are annotated via inline PR comments. After the updates:Type
Impact
Checklist