Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with multi-day durations. #543

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix an issue with multi-day durations. #543

merged 2 commits into from
Jul 23, 2024

Conversation

christinaholtNOAA
Copy link
Contributor

Synopsis

MPAS expects an underscore for multi-day forecasts when specifying forecast duration.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA self-assigned this Jul 23, 2024
@christinaholtNOAA christinaholtNOAA merged commit bf71bfb into ufs-community:main Jul 23, 2024
2 checks passed
christinaholtNOAA added a commit to christinaholtNOAA/uwtools that referenced this pull request Aug 1, 2024
@christinaholtNOAA
Fix an issue with multi-day durations. (ufs-community#543)
6c3bb36 
MPAS expects an underscore for multi-day forecasts when specifying forecast duration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

@WeirAE WeirAE Awaiting requested review from WeirAE WeirAE is a code owner

Assignees

@christinaholtNOAA christinaholtNOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christinaholtNOAA @maddenp-noaa @elcarpenterNOAA