-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept str values for config, target_dir in file tool #553
Merged
maddenp-noaa
merged 5 commits into
ufs-community:main
from
maddenp-noaa:file-tool-accept-str-target-dir
Aug 1, 2024
Merged
Accept str values for config, target_dir in file tool #553
maddenp-noaa
merged 5 commits into
ufs-community:main
from
maddenp-noaa:file-tool-accept-str-target-dir
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
changed the title
Accept str value for target_dir in file tool
Accept str values for config, target_dir in file tool
Jul 31, 2024
maddenp-noaa
commented
Jul 31, 2024
maddenp-noaa
commented
Jul 31, 2024
maddenp-noaa
requested review from
NaureenBharwaniNOAA,
christinaholtNOAA,
elcarpenterNOAA,
fgabelmannjr and
WeirAE
as code owners
July 31, 2024 22:52
elcarpenterNOAA
approved these changes
Aug 1, 2024
christinaholtNOAA
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
NaureenBharwaniNOAA
approved these changes
Aug 1, 2024
WeirAE
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
copy()
andlink()
convenience functions we provide viauwtools.api.file
, we now also provide direct access to theCopier
andLinker
objects, so that external drivers can instantiate them and use their tasks directly, e.g.yield
ing them as dependency tasks in their owniotaa
tasks. We already ensured thatstr
values provided by users incopy()
orlink()
calls are converted to thePath
objects expected byCopier
andLinker
. But it will be convenient for users to be able to providestr
values when they directly call the constructors of those classes. So, the necessary conversions are added.FileCopier
->Copier
(and similarlyFileLinker
->Linker
) to avoid the awkward repetition in e.g.uwtools.file.FileLinker
.FileStager
->Stager
is added here.Type
Impact
Checklist