Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public driver rundir attr, redefine config_full #558

Merged

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Aug 5, 2024

Synopsis

  1. Make the rundir property on driver objects public. It's useful to access this attribute in the context of task methods and, while that use case doesn't conflict with a private-attribute designation, it seems awkward to me, and I can't see a reason to hide this piece of information. Almost all the diffs are updates to conform to this change.
  2. Redefine the config_full attribute to be the full, dereferenced input config, which allows a e.g. coupled driver to pass it to a constituent driver's constructor. The platform config item, previously but no longer accessible via the config_full attribute, is now dealt with internally via a private attribute and does not need to be publicly exposed.

Type

  • Enhancement (adds new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Non-breaking because we have not yet released a uwtools exposing the config_full attribute.

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

Copy link
Contributor

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the pylint bug gets squashed!

@maddenp-noaa maddenp-noaa merged commit 50d73e0 into ufs-community:main Aug 5, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the more-public-driver-attrs branch August 5, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants